Repository navigation
Add bounded security property tests - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add bounded, fixed-seed property tests for security-sensitive input handling. Production code is unchanged.
Motivation
Exercise malformed inputs and deterministic matching boundaries through the existing test suite.
Changes
Add properties for webhook grouping and ordering, redaction, and GraphQL formatting invariance. Pin fast-check@4.10.2 as a development dependency and update the lockfile. The existing test workflow discovers the new tests.
Tests performed
npm test -- --test-reporter=dotpassed on Node 22.23.4 and 24.22.1 (122 tests).npm run lint,npm run coverage,npm audit --audit-level=high,npm run package:smoke,npm run action:checkandnpm pack --dry-runpassed.Compatibility
Tested locally on Node 22 and 24. No runtime behaviour or package version changed.
Security and privacy
Generated values are synthetic; redaction and offline review remain covered. No credentials, merchant or customer data, private source, production secrets, telemetry, Shopify network calls, or unsafe shell interpolation were added.
Shopify source/evidence
N/A. These test changes do not alter Shopify-specific behaviour.
Release impact
No consumer-facing change or npm release is required.
Checklist