perf(runtime): route local callbacks directly - #21
Closed
ReubenBond wants to merge 10 commits into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
rb-perf-runtime-route-callbacks-directly
branch
from
August 29, 2026 00:32
2e8b817 to
88ed247
Compare
Owner
Author
|
Superseded by dotnet#10913 after rebasing the branch onto upstream main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on dotnet#10886.
Local responses currently recover callback ownership through the shared callback table even though the originating request and response remain in the same process.
This change carries the exact callback identity on
Messageas process-local runtime state.MessageFactorytransfers it to success, rejection, and status responses, while message serialization intentionally omits it so forwarded and remote responses use the normal fallback path.The silo fallback path uses a correlation-ID-only 128-stripe callback table, relying on the singleton
MessageFactoryhost-uniqueness guarantee. Cleanup is identity-checked to prevent stale/ABA removal, shutdown closes admission and drains in-progress publication, scans use pooled snapshots, and exact test-only counts lock all stripes.OutsideRuntimeClientretains its existingConcurrentDictionarypath.Hosted-client measurements against dotnet#10886 show:
CPU profiles show inclusive response-callback processing samples falling from 689 ms to 204 ms. A SEDA callback-owner pipeline was also evaluated and rejected because its registration hop substantially regressed isolated latency and hot-sender throughput.