Skip to content

Prize RFPs: prize wording, Apply straight to workspace, role-based CTAs - #1275

Merged
yattias merged 2 commits into
mainfrom
claude/prize-rfp-tweaks
Nov 4, 2026
Merged

yattias merged 2 commits into
mainfrom
claude/prize-rfp-tweaks

Conversation

@yattias

@yattias yattias commented Nov 4, 2026

Copy link
Copy Markdown
Member

What changed

Prize wording. Award RFPs now read as prizes wherever they show:

  • RFP page: the pool card says "Prize pool", and the byline says "$X prize" and "Offers this prize". The list of top proposals is now "Prize winners", and the phone bar says "Add to prize".
  • Elsewhere: /fund feed cards, My Funding cards, the Add to pool panel, payment line items, success toasts and homepage activity lines.
  • Publish RFP screen: "Type" is now "Funding type". The options are Standard ("Fund new science") and Prize ("Award results submitted, competition style").

Regular funding RFPs keep their wording. Bounty "awards" are a separate feature and are untouched.

Apply goes straight to the workspace. Apply on the RFP's pool card and on the phone action bar now opens /workspace?new=proposal&rfp=<id>. ApplyToGrantPanel is deleted.

The workspace knows the RFP without fetching it. On Apply, the RFP page saves the RFP's name, image, amount, funder, visibility and type to sessionStorage (components/AIMode/rfpHandoff.ts), and the workspace reads them from there. This fixes the RFP chip that showed no name: /api/grant/<id>/ returns no title. That request is gone (GrantService.getSelectedGrant was removed).

"Submitting an application" indicator.

  • Start screen: when an RFP is picked, a card above the composer says "Submitting an application to", with the RFP, funder and amount (ApplyingToCard).
  • Drafts tied to an RFP: Publish reads "Submit application", in the floating button and in the top-bar button. The dialog is titled "Submit application" with a "Submit" button.

RFP Proposals tab. Prize proposal cards show "Awarded" plus the amount, never "Set aside". The set-aside tooltip is removed from the prize winners list.

Prize proposal card (proposal page sidebar).

  • The timeline gains a third step, Update posted. It is dated with the newest update and links to the Updates tab. The count comes from the author updates the layout already fetches.
  • Steps still to come read at full strength. Only a step that can no longer happen is dimmed.
  • The main button depends on who is looking:
    • Authors get Post update, which opens the Updates tab. This holds even when the author also created the RFP.
    • The RFP creator gets Award prize (or Award more).
    • Everyone else gets no button.
  • The phone action bar does the same.

RFP author badge missing on staging. That RFP's organization is empty, so the byline's funder row never rendered. GrantPageContext now falls back to the RFP creator's author profile for the name and avatar.

Visibility options. In the workspace publish dialog, "Applicant chooses" lists its points with checks instead of blue circles.

Network requests

None added, one removed. The workspace no longer calls /api/grant/<id>/ when opened with rfp=.

Reviewer notes

  • Direct links to the workspace: opening /workspace?new=proposal&rfp=<id> without coming from that RFP's page (shared link, new tab) starts with no RFP picked. The user picks it from the chip.
  • smoke/proposal.spec.ts will fail. It still clicks through the removed Apply panel (apply-draft-new → apply-continue) to /notebook. It needs rewriting for the Apply → workspace flow; not done here.
  • The sidebar Drafts list still can't show that a draft is an application: the notes listing endpoint doesn't return the draft's RFP. That needs a backend listing change.

Testing

  • npm run type-check, ESLint and Prettier pass (pre-commit hook).
  • Checked on a local dev server, signed in with the smoke test account:
    • On RFP 76 (prize), Apply opens the workspace with the RFP card and chip named, and no /api/grant request fires.
    • A blank-page draft tied to the RFP shows "Submit application".
    • The RFP publish dialog shows the new type labels and the checks.
    • Prize card author, funder and reader views were checked on a throwaway preview page.

🤖 Generated with Claude Code

- Award RFPs read as prizes across the RFP page, feeds, My Funding,
  payments and activity lines; the RFP type choice is now "Funding type"
  with Standard and Prize.
- Apply on an RFP goes straight to /workspace?new=proposal&rfp=<id>; the
  Apply panel is removed. The RFP page hands its details to the workspace
  through sessionStorage, so the start screen names the RFP without
  fetching it.
- The start screen shows which RFP the proposal applies to, and a draft
  tied to an RFP says "Submit application" instead of Publish.
- Proposal cards on RFP pages show "Awarded" instead of "Set aside".
- The prize proposal card gains an "Update posted" step. Authors get Post
  update as the main button; the RFP creator gets Award prize.
- The RFP byline falls back to the RFP's creator when it has no
  organization.
- Applicant chooses lists its points with checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yattias
yattias requested a review from a team as a code owner November 4, 2026 18:35
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
web Ready Ready Preview Nov 4, 2026 6:38pm UTC

Request Review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-04T18:36:01.086939Z
We couldn’t complete this review. Comment @codex review to try again.
b6c352b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@yattias
yattias merged commit 1f389c8 into main Nov 4, 2026
1 of 2 checks passed
@yattias
yattias deleted the claude/prize-rfp-tweaks branch November 4, 2026 18:37
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

This branch was successfully deployed

1 active deployment
Preview — 3f1ec1b8 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant