Repository navigation
Add LaTeX math rendering for proposals and discussions #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aeff6b8
Add LaTeX math rendering for proposals and discussions.
nicktytarenko 3a69a65
Merge branch 'main' of https://github.com/ResearchHub/web into featur…
nicktytarenko 398b6d7
Update INLINE_MATH_REGEX to exclude display math and improve regex ac…
nicktytarenko 2d330c6
Fix BLOCK_MATH_REGEX to correctly match display math syntax
nicktytarenko 3d1a0c1
Enhance TipTapRenderer to exclude code marks from text nodes before p…
nicktytarenko c8fa8c2
Merge branch 'main' into feature/latex-math-rendering
nicktytarenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| 'use client'; | ||
|
|
||
| import katex from 'katex'; | ||
| import { cn } from '@/utils/styles'; | ||
|
|
||
| /** `$...$` inline only — excludes `$$` so display math is not partially eaten. */ | ||
| export const INLINE_MATH_REGEX = /(?<!\$)\$(?!\$|\d+\$)(.+?)(?<!\$)\$(?!\$|\d)/g; | ||
|
|
||
| export const BLOCK_MATH_REGEX = /^\$\$([\s\S]+?)\$\$$/; | ||
|
|
||
| interface KatexMathProps { | ||
| latex: string; | ||
| display?: boolean; | ||
| className?: string; | ||
| } | ||
|
|
||
| /** | ||
| * Renders a LaTeX string with KaTeX. Falls back to the raw source when | ||
| * KaTeX cannot parse it so comments stay readable instead of blank. | ||
| */ | ||
| export function KatexMath({ latex, display = false, className }: KatexMathProps) { | ||
|
Check warning on line 21 in components/Comment/lib/KatexMath.tsx
|
||
| try { | ||
| const html = katex.renderToString(latex, { | ||
| displayMode: display, | ||
| throwOnError: false, | ||
| }); | ||
| return ( | ||
| <span | ||
| className={cn( | ||
| 'tiptap-math', | ||
| display | ||
| ? 'tiptap-block-math my-3 block overflow-x-auto text-center' | ||
| : 'tiptap-inline-math', | ||
| className | ||
| )} | ||
| dangerouslySetInnerHTML={{ __html: html }} | ||
| /> | ||
| ); | ||
| } catch { | ||
| return ( | ||
| <code | ||
| className={cn( | ||
| 'tiptap-math-error bg-gray-100 px-1 rounded text-sm', | ||
| display && 'my-3 block overflow-x-auto', | ||
| className | ||
| )} | ||
| > | ||
| {latex} | ||
| </code> | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.