Skip to content

[2.2] Update coordination strategy of FlatSearchCommandHandler - #331

Open
Skoucail wants to merge 1 commit into
RediSearch:2.2from
Skoucail:issue-326
Open

[2.2] Update coordination strategy of FlatSearchCommandHandler#331
Skoucail wants to merge 1 commit into
RediSearch:2.2from
Skoucail:issue-326

Conversation

@Skoucail

@Skoucail Skoucail commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Add MRCluster_MastersOnly to the coordination strategy of the FlatSearchCommandHandler
This fixes #326

Add MRCluster_MastersOnly to the coordination strategy of the FlatSearchCommandHandler
@Skoucail

Skoucail commented Dec 2, 2021

Copy link
Copy Markdown
Contributor Author

@rafie
Can you help me?
I have no clue why that 1 single test fails on the build server because of my PR

@rafie

rafie commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Hello @Skoucail, this is a flaky test, just needs a re-run.
However, please note we no longer accept PRs on the RSCoordinator repo (as RSCoordinator is now integrated into the RediSearch repo). Instead, please open a PR on RediSearch/master, and modify files under the coord directory. Thanks!

@Skoucail

Skoucail commented Dec 2, 2021

Copy link
Copy Markdown
Contributor Author

@rafie
Oh okee, didnt know this repo is depricated now.
I did a test with the RediSearch 2.2 branch. Same issue.
So i recreated the pull request over in RediSearch: RediSearch/RediSearch#2404

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants