Repository navigation
docs: ADR 0011 — on-node eBPF CPU profiling - #25
Merged
Merged
Conversation
Decide the node-role eBPF CPU profiler ahead of implementation (ADR-first). - ADR 0011: embed go.opentelemetry.io/ebpf-profiler as a library (no own profiler), symbolize on the node so client binaries never leave it; CAP_BPF+CAP_PERFMON with no privileged and a kernel-5.8+ graceful refusal; a config-bounded node->controller targeting query framed as a scoped exception to 0010 §1 (the node's ConfigMap bounds the eligible set and all ceilings, the controller can only prioritize within them); on-node symbol allow-list filtering; profile validation; spool payload keyed source=ebpf; GPL-2.0 isolation + NOTICE. Records the PGO-spike outcome: eBPF feeds flame graphs/coverage, not PGO (deferred). - security.md §7.2: pin capabilities, kernel gate, node-side symbolization, config-bounded targeting. - security.md §8: symbol-filter policy (client allow-list + stdlib/runtime kept, third-party dropped by default), on-node validation, eBPF != PGO. - docs/spikes/ebpf-pgo.md: the PGO spike record (eBPF output omits Function.start_line -> `go build -pgo` fails), scrubbed for public docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1 of the eBPF node-profiling feature: the ADR-first design gate. Docs only, no runtime code.
What this decides (ADR 0011)
go.opentelemetry.io/ebpf-profileras a library (no own profiler); symbolize on the node — client binaries never leave their node.CAP_BPF+CAP_PERFMON, neverprivileged, gated on kernel 5.8+ with a graceful refusal + counter (scanner role unaffected).cpu/nanoseconds, service funcs in top) → invalid dropped + counted, never sent.source=ebpf); golden-tested wrapper.Also in this PR
security.md§7.2 (capabilities, kernel gate, node-side symbolization, config-bounded targeting) and §8 (symbol-filter policy, validation, eBPF ≠ PGO).docs/spikes/ebpf-pgo.md: the PGO spike record — eBPF output omitsFunction.start_line, sogo build -pgofails → PGO deferred; eBPF is flame-graphs/coverage only. Scrubbed for public docs.Not in this PR
Implementation lands in later slices: kernel-gate + manifest capabilities → profiler+reporter integration → symbol filtering → validation+spool+golden → targeting → kind e2e.
🤖 Generated with Claude Code