Repository navigation
test: the collection listing is proved from inside the pod and refused from outside (ADR 0084) - #126
Merged
Merged
Conversation
…ide (ADR 0084)
Two claims the unit tests cannot settle: that the names and reasons are right
when the owner chains and namespace annotations come from a real API server,
and that what the chart actually binds is reachable from the pod and nowhere
else.
The controller's spool-reader sidecar shares the pod's network namespace, which
is the whole of what loopback grants, so it reads the listing with no port, no
policy and no credential. A second pod asking the controller's own address is
refused at connect.
Exec against one container was written twice; execSpoolReader now names its
container and delegates.
make collection-e2e # PASS 4.4s, self-opted by pod_annotation,
# 10.244.0.38:9091 connection refused from another pod
make policy-e2e # PASS 64s, the refactored exec still reads the spool
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KeZECJXTDHL6Nts95eKMJA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #125, which shipped the listing without an e2e test. Two of its claims are properties of a deployed agent rather than of a handler, so the unit tests cannot settle either:
How it is asserted
The controller's spool-reader sidecar shares the pod's network namespace — which is the whole of what loopback grants — so it reads
127.0.0.1:9091/collectionwith no port, no NetworkPolicy and no credential. A second pod, in another namespace, then asks the controller's own address and must be refused at connect.The install allows one fixture namespace, so all three answers appear in one run: a collected pod, a pod that opted itself out, and everything else refused by the configuration.
Evidence
Also in here
Exec against one container of one pod was written twice.
execSpoolReadernow names its container and delegates toexecIn.🤖 Generated with Claude Code
https://claude.ai/code/session_01KeZECJXTDHL6Nts95eKMJA