Skip to content

Fix spectator-sync incorrectly suppressing visuals when the local player is being spectated. (Issue #7) - #9

Closed
hollyntt wants to merge 4 commits into
Read1dno:mainfrom
hollyntt:main
Closed

hollyntt wants to merge 4 commits into
Read1dno:mainfrom
hollyntt:main

Conversation

@hollyntt

Copy link
Copy Markdown

Summary

The visual suppression logic previously used local_spectated(), which represents other players watching the local player. This could incorrectly suppress visuals during normal gameplay.

Added a separate local_spectating_other() signal that is set only when the local player is dead and actively spectating another player. Both player visuals and overlay suppression now use this signal.

I even updated cmake presets for it to work for me cause why not.

Issues related:
#7

Verification

  • Release build succeeds
  • [100% tests passed out of 3 | Total Test time (real) = 0.15 sec] Relevant tests pass
  • No generated files, binaries, credentials or personal data are included
  • User-visible behavior and documentation are updated where necessary

@8ktv

8ktv commented Sep 14, 2026

Copy link
Copy Markdown

did u actually test it?

@hollyntt

Copy link
Copy Markdown
Author

@Read1dno Read1dno closed this Sep 15, 2026
@Read1dno

Copy link
Copy Markdown
Owner

Closing this pull request without merging.

The reported spectator-sync behavior is intentional: ESP is disabled when another player is spectating the local player. This PR changes that intended behavior by treating local spectating as the suppression condition.

The proposed changes also include unrelated build changes and are not suitable for merging as-is.

@hollyntt

Copy link
Copy Markdown
Author

its intentional? danm, ig thats gonna be annoying. it is what it is though. ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants