Repository navigation
Conversation
This is for Read1dno to prepare
|
did u actually test it? |
Author
https://medal.tv/games/counter-strike-2/clips/nwEJbCq6XFRFYelPi?invite=cr-MSxuM1MsNjY5ODM3NjYz |
Owner
|
Closing this pull request without merging. The reported spectator-sync behavior is intentional: ESP is disabled when another player is spectating the local player. This PR changes that intended behavior by treating local spectating as the suppression condition. The proposed changes also include unrelated build changes and are not suitable for merging as-is. |
Author
|
its intentional? danm, ig thats gonna be annoying. it is what it is though. ¯_(ツ)_/¯ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The visual suppression logic previously used
local_spectated(), which represents other players watching the local player. This could incorrectly suppress visuals during normal gameplay.Added a separate
local_spectating_other()signal that is set only when the local player is dead and actively spectating another player. Both player visuals and overlay suppression now use this signal.I even updated cmake presets for it to work for me cause why not.
Issues related:
#7
Verification