Repository navigation
Conversation
- Extend render::localization::id with zh_cn and zh_tw entries - Add full translation tables (~509 strings) for both languages, including grenade throw type fallback keys and ESP editor labels - Dispatch tr() per language; code() returns CN/TW - Add 简体中文/繁體中文 entries to the Misc language selector - Merge a system CJK font (msyh/msjh/simsun) into menu, HUD and ESP text fonts with Chinese glyph ranges so localized text renders - Update README interface description
- Extend begin_row and all row widgets with an optional description string; hovering a setting label for 3 seconds opens a styled popup with the translated description - draw_row_tooltip renders a 320px popup matching the menu popup style (soft shadow, popup surface, wrapped text, bounds-clamped position) - Thread descriptions through toggle/slider/select/multiselect/keybind/ color/button/text-input/settings/toggle popup rows - Wire 54 descriptions into combat, visuals and misc pages - Add Simplified and Traditional Chinese translations for all description keys to both localization tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds hover tooltips to the settings menu: hovering a setting's label for 3 seconds opens a popup with a detailed description of what the feature does.
Implementation
Core (
layout.cpp/internal.hpp)begin_row(label, control_width)gains an optional trailingconst char *descriptionparameter — it is the chokepoint every row widget funnels through, and already computes the label text rect.g_row_hover_timemap (ImGuiID → elapsed seconds), accumulatingio.DeltaTimewhile the mouse stays inside the label rect; leaving the label resets the timer. At ≥ 3 s the tooltip is drawn.draw_row_tooltip()renders a 320 px-wide popup matching the existing menu popup style: soft shadow +draw_popup_surface(rounding 10) + wrapped text, positioned below the label and clamped to the menu bounds.Widgets (
widgets.cpp/popups.cpp)toggle_row,toggle_color_row,slider_row(int/float),slider_percent_row,select_row,multiselect_row,button_row,text_input_row,keybind_row,color_row,settings_popup_row,toggle_popup_row, and theslider_row_impltemplate. Existing call sites are unaffected (parameter defaults tonullptr).Pages
Localization
Testing
cmake --build --preset release --parallelbuilds clean on MSVC.Depends on the Simplified/Traditional Chinese localization PR (#12) — this branch contains that commit plus the tooltip work.