feat: Various misc QoL enchancements - #3459
Draft
oSumAtrIX wants to merge 28 commits into
Draft
Conversation
Replacing the last line (heartbeat-tick case) avoids splitting the whole message into a list and rejoining it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was added
Live updates for patcher screen
Implemented live updates for: Decoding resources
Decoding resources [space] Xs)every second, replacing in placeDecoded resources in Xsreplaces the live tick[INFO] Applying patches[INFO] Decoded resources in 31s[INFO] Writing patched files...Implemented live updates for: Downloading APK file
Download APK file [spacer] [size] - Xs)every second, replacing in placeDownloaded APK file in Xs [spacer] [size]replaces the live tick[INFO] Applying patches[INFO] Decoded resources in 31s[INFO] Writing patched files...CI: Skip automatic builds for drafts
As the title implies, it just prevents GitHub Actions to build on PR drafts, everything else it unchanged (i.e. keeps building on commits)
Clear downloaded APK cache
Just a button under
Settings=>Developer optionsto clear the cache of downloaded APKsImage preview
Fix network memory leak
The flow for donwloads is:
Every read operation allocates a small byte container, everything writes correctly, but the containers are never freed from memory after use, causing them to persist and accumulate
To fix this, we wrap each chunk inside a
.use { }blocks for automatic resource management:Instead of wrapping the main logic in an
if (success)check, it now throws early if it failsIt keeps the exact same behavior but saves us a level of indentation and its better practice
Fixes #3392
Dedicated dialogs for patcher kills and native crashes
ProcessRuntimethrows a genericExceptionfor any non-zero exit code from the patcher subprocess, leaving users with the generic "Process exited with nonzero exit code X"A good example is on #3060 which on low-RAM devices is almost always Android's LowMemoryKiller, not a real bug
Added signal exit codes to two typed exceptions routed to dedicated
InstallerStatusDialogkinds:PatcherKilledExceptionfor when the system terminates the processPatcherCrashedExceptionfor when the process crashed nativelyAnd
InstallerModelnow has aretry()so the dialog button can a clean install attempt can be tried from the installer screenSoft-skip failed patches - WIP!
When a patch fails, the entire process dies, this addition makes it so keeps patching, skipping the failed patch
Image preview
Fix step icons not aligned
Image preview
Removed useless prefix
The prefix
[INFO]is useless and shouldn't be there, removed only for the INFO levelStyling and refactor
`strings.xml` has style tags like `` but it doesn't work, now it does!
Now these components animate: