Skip to content

feat: Redesign SelectedAppInfoScreen - #3246

Draft
Ushie wants to merge 4 commits into
devfrom
feat/redesign-selected-app-info
Draft

feat: Redesign SelectedAppInfoScreen#3246
Ushie wants to merge 4 commits into
devfrom
feat/redesign-selected-app-info

Conversation

@Ushie

@Ushie Ushie commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

Based on #3235, continuation of #3241 made by @planshim

Video preview, non-final design
Screen_Recording_20260329_063348_ReVanced_Manager_Debug.mp4

@oSumAtrIX

This comment was marked as resolved.

@Ushie

This comment was marked as resolved.

@Ushie
Ushie force-pushed the feat/redesign-selected-app-info branch 2 times, most recently from d90bef7 to 19bddee Compare April 1, 2026 18:09
@PalmDevs

Copy link
Copy Markdown
Member

Is this still active?

@Ushie

Ushie commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

No, there's complications involved

@Ushie Ushie closed this Jun 27, 2026
@oSumAtrIX

Copy link
Copy Markdown
Member

The redesign is still relevant, which complications?

@oSumAtrIX oSumAtrIX reopened this Jun 27, 2026

@TUSHAR91316 TUSHAR91316 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redesign looks great! The blurred icon header and BannerScaffold integration are a huge visual improvement.

While reviewing the implementation, I noticed a few logic issues that need a fix:

  1. compact?.let bug in Sections.kt:
    In InfoListItem, compact defaults to false. Because false is not null, compact?.let { ... return@Surface } always executes and returns early. This prevents the expanded Column and its action buttons (like "Open downloaders") from ever rendering.

    • Fix: Use if (compact == true) { instead of compact?.let {.
  2. Inverted warning conditions in SelectedAppInfoScreen.kt:

    • if (!hasModifiedPatchSelection) shows the "Patch selection has changed" warning when the selection has not been modified.
    • if (!showVersionCompatibilityWarning) shows the compatibility warning when the version is compatible.
    • Fix: Remove the ! negation from both conditions.
  3. Safeguard parameter in SelectedAppInfoScreen.kt:
    In onPatchSelectorClick, allowIncompatiblePatches is passed instead of effectiveAllowIncompatible to vm.getCustomPatches().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants