feat: Redesign SelectedAppInfoScreen - #3246
Conversation
Co-authored-by: planshim <100317079+planshim@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
d90bef7 to
19bddee
Compare
|
Is this still active? |
|
No, there's complications involved |
|
The redesign is still relevant, which complications? |
TUSHAR91316
left a comment
There was a problem hiding this comment.
The redesign looks great! The blurred icon header and BannerScaffold integration are a huge visual improvement.
While reviewing the implementation, I noticed a few logic issues that need a fix:
-
compact?.letbug inSections.kt:
InInfoListItem,compactdefaults tofalse. Becausefalseis notnull,compact?.let { ... return@Surface }always executes and returns early. This prevents the expandedColumnand its action buttons (like "Open downloaders") from ever rendering.- Fix: Use
if (compact == true) {instead ofcompact?.let {.
- Fix: Use
-
Inverted warning conditions in
SelectedAppInfoScreen.kt:if (!hasModifiedPatchSelection)shows the "Patch selection has changed" warning when the selection has not been modified.if (!showVersionCompatibilityWarning)shows the compatibility warning when the version is compatible.
- Fix: Remove the
!negation from both conditions.
-
Safeguard parameter in
SelectedAppInfoScreen.kt:
InonPatchSelectorClick,allowIncompatiblePatchesis passed instead ofeffectiveAllowIncompatibletovm.getCustomPatches().
Based on #3235, continuation of #3241 made by @planshim
Video preview, non-final design
Screen_Recording_20260329_063348_ReVanced_Manager_Debug.mp4