add setnafill support for character vectors#7748
Open
ben-schwen wants to merge 3 commits into
Open
Conversation
MichaelChirico
approved these changes
May 13, 2026
Member
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
I guess we should add a test of set() behavior per se where we ensure the delta of addresses is as intended?
Generated via commit 6cce6fd Download link for the artifact containing the test results: ↓ atime-results.zip
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7748 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 87 87
Lines 17065 17064 -1
==========================================
- Hits 16902 16901 -1
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jangorecki
reviewed
May 13, 2026
| for (R_len_t i=0; i<nx; i++) { | ||
| vans[i] = ((ans_t) { .dbl_v=dx[i], .int_v=ix[i], .int64_v=i64x[i], .status=0, .message={"\0","\0","\0","\0"} }); | ||
| SEXP xi = VECTOR_ELT(x, i); | ||
| vans[i] = ((ans_t) { .dbl_v=dx[i], .int_v=ix[i], .int64_v=i64x[i], .char_v=isString(xi) ? xi : R_NilValue, .status=0, .message={"\0","\0","\0","\0"} }); |
Member
There was a problem hiding this comment.
Isn't it the first time we use .char_v field of ans_t?
Line 13 in 188dd7b
says to not use it in parallel
Member
Author
There was a problem hiding this comment.
I thought thats what the any_char guarding is about in
#pragma omp parallel for if (nx>1 && !any_char) num_threads(getDTthreads(nx, true))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7586 #3992
Maybe I'm overlooking smth here because the addition seems to easy