Remove API Key - #49
Merged
Merged
Conversation
Add URL, method, params, status_code, and response_text to HevyAPIError exceptions so sync/webhook failures are actionable in production logs. - HevyAPIError now carries structured request/response metadata - sync.py logs page, since, and full context on API errors - api.py webhook handler logs the same context on fetch failures - Update tests to assert on the new error attributes
The Hevy API returns HTTP 404 when requesting a page beyond the last available page of workout events. Previously, any HevyAPIError (including 404) was caught by the outer exception handler, which aborted the entire sync run before the watermark could advance. This caused an infinite loop of re-processing the same pages and crashing on page 13. Now, 404 inside the pagination loop is treated as end-of-data and breaks the loop gracefully, allowing the sync state watermark to be updated. Other API errors (401, 429, 5xx, etc.) still abort as before. Also added a regression test to prevent this from happening again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.