Repository navigation
knative: Fix Eventing detail cluster checks and filter summaries - #4
Draft
kahirokunn wants to merge 5 commits into
Conversation
Signed-off-by: RajPrakash681 <rjnt452@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
fix/knative-eventing-detail-corrections
branch
from
October 17, 2026 17:58
a5bb816 to
879bfb8
Compare
kahirokunn
marked this pull request as draft
October 17, 2026 18:07
kahirokunn
force-pushed
the
fix/knative-eventing-detail-corrections
branch
from
October 17, 2026 19:04
23bb33d to
879bfb8
Compare
Author
|
@RajPrakash681 Hi ✋ PTAL. Thank you 🙏 |
RajPrakash681
force-pushed
the
feat/knative-eventing-detail-pages
branch
from
October 17, 2026 20:18
6b65202 to
05df156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to headlamp-k8s#1353, targeting its feature branch.
Broker and Trigger details now check Eventing installation only in the resource's active cluster and pass that same cluster to
DetailsGrid. Selecting another cluster without Eventing no longer hides an existing resource's detail page.Trigger filter summaries now show the configured expression tree instead of predicting broker delivery. Groups, member order, and repeated conditions remain visible; empty, incomplete, and multiple-dialect expressions retain their JSON representation. For example,
any: [{ all: [{}] }, { exact: { type: 'a' } }]displaysany of (all of ({}); type = a)instead ofAll events. The existingfilters/legacyfilterprecedence and the formatter's public signature are unchanged.Validation in
knative/:npm run tscnpm run lintnpm run format -- --checknpm test— 227 tests passed, including mixed-cluster, missing-installation, loading, and cluster-navigation casesnpm run buildThe mixed-cluster regression tests fail before the cluster fix. Live-cluster UI verification was not performed.