[AppleAppStoreBridge] replace regex with string search to extract serialized server data - #5024
Merged
Conversation
…ialized server data The `preg_match` regex used to extract the `serialized-server-data` JSON block from Apple's HTML page fails when the JSON payload exceeds ~1MB, hitting PHP's default PCRE backtrack limit (1,000,000). This causes a "Failed to locate serialized server data in HTML page" error on every request. Replaced the regex-based extraction with `strpos/substr` string operations, which have no backtrack limit and handle arbitrarily large payloads reliably.
Pull request artifacts
last change: Thursday 2026-07-02 18:34:50 |
Contributor
Author
|
This fix is necessary for some App Store pages with lots of versions, such as https://apps.apple.com/us/app/youtube/id544007664. This has now been fixed (see https://rss-bridge.noh.am/?action=display&bridge=AppleAppStoreBridge&id=544007664&p=mac&country=US&format=Atom). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
preg_matchregex used to extract theserialized-server-dataJSON block from Apple's HTML page fails when the JSON payload exceeds ~1MB, hitting PHP's default PCRE backtrack limit (1,000,000). This causes a "Failed to locate serialized server data in HTML page" error on every request.Replaced the regex-based extraction with
strpos/substrstring operations, which have no backtrack limit and handle arbitrarily large payloads reliably.