Skip to content

Bumping TheROCK commit hash to include stage skip feat - #10922

Open
ammallya wants to merge 1 commit into
developfrom
users/ammallya/bump-therock
Open

Bumping TheROCK commit hash to include stage skip feat#10922
ammallya wants to merge 1 commit into
developfrom
users/ammallya/bump-therock

Conversation

@ammallya

Copy link
Copy Markdown
Collaborator

Motivation

Bumping TheROCK commit hash to include stage skip feature

Copilot AI lite review requested due to automatic review settings August 28, 2026 22:46
@ammallya
ammallya requested a review from a team as a code owner August 28, 2026 22:46
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Aug 28, 2026
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this repo’s GitHub Actions workflows to pin ROCm/TheRock to a newer commit (b5fe0400d52053ff4fc95971f165d992084ba682, dated 2026-08-28) so CI picks up the referenced “stage skip” feature from TheRock.

Changes:

  • Bump all actions/checkout usages that fetch ROCm/TheRock to the new pinned commit.
  • Bump all reusable-workflow uses: ROCm/TheRock/.github/workflows/...@<sha> references to the same new commit.
  • Update workflow input defaults (therock_ref) used by RCCL workflows to the new commit.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/therock-test-packages.yml Update TheRock checkout ref to the new pinned commit.
.github/workflows/therock-test-component.yml Update TheRock checkout ref(s) used for component testing.
.github/workflows/therock-rccl-test-rocprof.yml Update TheRock checkout ref used by rocprof test workflow.
.github/workflows/therock-rccl-test-pytorch-distributed.yml Update TheRock checkout ref used by PyTorch distributed tests.
.github/workflows/therock-rccl-test-packages-single-node.yml Update TheRock checkout ref used by single-node RCCL package tests.
.github/workflows/therock-rccl-test-packages-multi-node.yml Update TheRock checkout ref used by multi-node RCCL package tests.
.github/workflows/therock-rccl-test-jax-collective.yml Update TheRock checkout ref used by JAX collective tests.
.github/workflows/therock-rccl-ci-linux.yml Update TheRock checkout ref used by RCCL CI on Linux.
.github/workflows/therock-multi-arch-ci.yml Update TheRock reusable-workflow pins and checkout ref to the new commit.
.github/workflows/therock-multi-arch-ci-nightly.yml Update pinned TheRock commit reference and all related reusable-workflow pins.
.github/workflows/therock-multi-arch-ci-asan.yml Update TheRock reusable-workflow pins and checkout ref for ASAN CI.
.github/workflows/therock-multi-arch-ci-asan-nightly.yml Update TheRock reusable-workflow pins and checkout ref for ASAN nightly.
.github/workflows/therock-ci.yml Update TheRock checkout ref used by the main TheRock CI workflow.
.github/workflows/therock-ci-windows.yml Update TheRock checkout ref used by Windows CI workflow.
.github/workflows/therock-ci-linux.yml Update TheRock checkout ref used by Linux CI workflow.
.github/workflows/therock-build-linux.yml Update TheRock checkout ref used by Linux build workflow.
.github/workflows/rccl-suite.yml Update default therock_ref input to the new pinned commit.
.github/workflows/rccl-ci.yml Update default therock_ref input and propagated therock_ref usage to the new commit.
.github/workflows/media-libs-ci.yml Update TheRock checkout ref used by media-libs CI workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants