feat(rocprofiler-sdk) add initial pc sampling skill - #10915
Open
samcrater-amd wants to merge 2 commits into
Open
feat(rocprofiler-sdk) add initial pc sampling skill#10915samcrater-amd wants to merge 2 commits into
samcrater-amd wants to merge 2 commits into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
MythreyaK
approved these changes
Aug 28, 2026
MythreyaK
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but
- skills here could be mistaken (by humans and agents) for "skill to use when developing / working on rocprofiler-sdk/rocprofv3", not with them
- might be worth adding to perfexpert as well
- we should probably check with repo owners as an additional review to see if we can add them here for now
ApoKalipse-V
approved these changes
Aug 29, 2026
| --pc-sampling-beta-enabled \ | ||
| --pc-sampling-method stochastic \ | ||
| --pc-sampling-unit cycles \ | ||
| --pc-sampling-interval 131072 \ |
Contributor
There was a problem hiding this comment.
@vlaantic Should we recommend the maximum interval here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds a skill to rocprofiler-sdk telling AI agents how to use the basics of rocprof's PC sampling. Skills we make live in our repository and will automatically be pulled into the central amd/skills repository once registered with there.
Issue Tracking
There is no JIRA ticket for this task.
Testing
Manually pulled the skill into a local copy of amd/skills and ran the publish and check scripts; came back clean.
Submission Checklist