Skip to content

feat(rocprofiler-sdk) add initial pc sampling skill - #10915

Open
samcrater-amd wants to merge 2 commits into
developfrom
users/scrater/rocprof-pc-sampling-skill
Open

feat(rocprofiler-sdk) add initial pc sampling skill#10915
samcrater-amd wants to merge 2 commits into
developfrom
users/scrater/rocprof-pc-sampling-skill

Conversation

@samcrater-amd

@samcrater-amd samcrater-amd commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Motivation

Adds a skill to rocprofiler-sdk telling AI agents how to use the basics of rocprof's PC sampling. Skills we make live in our repository and will automatically be pulled into the central amd/skills repository once registered with there.

Issue Tracking

There is no JIRA ticket for this task.

Testing

Manually pulled the skill into a local copy of amd/skills and ran the publish and check scripts; came back clean.

Submission Checklist

@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocprofiler-sdk/skills/pc-sampling/scripts/analyze_pc_sampling.py; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@MythreyaK MythreyaK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but

  • skills here could be mistaken (by humans and agents) for "skill to use when developing / working on rocprofiler-sdk/rocprofv3", not with them
  • might be worth adding to perfexpert as well
  • we should probably check with repo owners as an additional review to see if we can add them here for now

--pc-sampling-beta-enabled \
--pc-sampling-method stochastic \
--pc-sampling-unit cycles \
--pc-sampling-interval 131072 \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlaantic Should we recommend the maximum interval here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants