Skip to content

fix(rocjitsu): correct gfx1250 v_cls_i32 semantics - #10914

Open
amd-eochoalo wants to merge 1 commit into
developfrom
users/amd-eochoalo/2026-08-28/issue-10805
Open

fix(rocjitsu): correct gfx1250 v_cls_i32 semantics#10914
amd-eochoalo wants to merge 1 commit into
developfrom
users/amd-eochoalo/2026-08-28/issue-10805

Conversation

@amd-eochoalo

Copy link
Copy Markdown
Contributor

Motivation

Correct v_cls_i32 semantics on gfx1250 to prevent corruption of signed int64 to float conversions.

Technical Details

  • Return 0xffffffff when all operand bits equal the sign bit.
  • Return the full leading-sign-bit count for all other inputs.
  • Update scalar, semantic-lowering, and SIMD code-generation paths.
  • Regenerate the checked-in ISA sources.
  • Add regression coverage for VOP1/VOP3 and scalar/SIMD execution.

Issue Tracking

Closes #10805

Test Plan

  • Run the focused gfx1250 v_cls_i32 regression test.
  • Run the AMD ISA generator tests.

Test Result

  • Gfx1250SimulationTest.VClsI32CountsLeadingSignBits: passed.
  • AMD ISA generator tests: 26 passed.
  • Build completed successfully.

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rocJITsu][gfx1250] v_cls_i32 is off by one and mishandles all-sign-bit inputs, corrupting int64-to-float conversions

1 participant