fix(tensilelite): address AIHPBLAS-3868 characterization gaps - #12004
Draft
newling wants to merge 5 commits into
Draft
fix(tensilelite): address AIHPBLAS-3868 characterization gaps#12004newling wants to merge 5 commits into
newling wants to merge 5 commits into
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## users/davidd-amd/mut-v2-combined-godfile #12004 +/- ##
=========================================================================
Coverage 70.67% 70.68%
=========================================================================
Files 2810 2810
Lines 462487 462487
Branches 68090 68090
=========================================================================
+ Hits 326859 326866 +7
+ Misses 112070 112066 -4
+ Partials 23558 23555 -3
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-3868
Motivation
TensileLite's configuration-driven tests exercise many GPU assembly-generation paths without requiring a GPU. The stack ending in #11970 increased that coverage, but most saved results recorded only the solution-derived kernel name and emitter return code. An emitted instruction could therefore change incorrectly without failing the corresponding test, while unrelated solution-state changes could still churn the saved kernel names.
The stack also admitted one unsupported MX scale layout until kernel emission, selected only the first problem group from multi-group YAML files without recording that choice, and contained repeated test code that generated the same kernels twice.
Technical Details
This PR follows #11970 and addresses the five findings from the stack review.
BenchmarkProblemsindex in their parameter lists and test names.Test Plan
Run the changed TensileLite unit and configuration-driven characterization tests, the complete characterization suite under coverage, the strict YAML corpus check, and the per-file coverage gate. Automated GitHub checks must provide the final gfx1250 compiler coverage.
Test Result
developmerge-tree codegen suite: 416 passed, 1 expected failure, 1 unexpected pass.Submission Checklist
Risk level
Medium (3/5): the production change rejects one unsupported gfx1250 MX layout earlier in solution derivation. Valid layouts are unchanged, but the generator path and a broad set of saved characterization results require gfx1250 validation in automated GitHub checks.