Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
changed the title
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
Looks like default Ubuntu 20.04 LTS + Debian 10 and earlier, are the common OS default which will now fail and require the cmake build and install. If you test build from source on that let us know.
Is 3.17 the new standard for rocm-libraries? Fine if you don't know.
One could require different versions for this custom build type (USE_CUDA is a non standard build) but probably best to keep it simple like you have done here.
rocBLAS should get the same bump as these are usually built as a set, and look at rocSOLVER too.
Ubuntu 20.04 ships CMake 3.16.3, so currently
Standard in rocm-libraries, there isn't really one. There are currently 13 different minimum versions, ranging from CMake 3.5 in rocALUTION to CMake 3.25.2 in hipBLASLt, hipDNN, and others.
They're not currently in lockstep, rocBLAS already requires 3.24.4 (i.e. already ahead of hipblas). I don't think it should be a requirement on this PR to put them in lockstep, we can make a follow-up PR if that is a stated goal I think? LMKWYT |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11988 +/- ##
========================================
Coverage 70.55% 70.55%
========================================
Files 2810 2810
Lines 462508 462508
Branches 68099 68099
========================================
Hits 326292 326292
Misses 112675 112675
Partials 23541 23541
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@TorreZuk ping |
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
Recommend fixed version for download and build otherwise okay.
Will ask around on latest standardization efforts
| install_packages | ||
|
|
||
| if [ -z "$CMAKE_VERSION" ] || $(dpkg --compare-versions $CMAKE_VERSION lt 3.16.8); then | ||
| if [ -z "$CMAKE_VERSION" ] || $(dpkg --compare-versions $CMAKE_VERSION lt 3.17.0); then |
There was a problem hiding this comment.
Did you test build yet? Could you go with 3.17.5 here that has fixes
3 participants
JIRA ID : LCOMPILER-876
Related PRs: #7235, #11808
Motivation
A planned hipBLAS CUDA-backend change replaces legacy CUDA package discovery with CMake's FindCUDAToolkit. This module and its imported CUDA targets were added in CMake 3.17. CMake 3.17.0 was released on March 20, 2020.
hipBLAS currently declares CMake 3.5 as its minimum while its installer and documentation specify 3.16.8. A later CUDA-backend change cannot use FindCUDAToolkit while those versions remain supported. This PR establishes the required CMake floor separately so the compatibility change can be reviewed before the backend migration.
Technical Details
The top-level hipBLAS project and its client project now require CMake 3.17. The dependency installer detects versions older than 3.17.0 and can download the 3.17.0 source release. The Linux and Windows installation guides report the same minimum. This PR does not change backend selection, CUDA package discovery, library sources, or device behavior.
Validation confirmed that hipBLAS configures with CMake 3.17.0, CMake 3.16.8 is rejected by the declared minimum, and FindCUDAToolkit is available only in the newer version.