[CI] Enable ManyLinux builds for release - #1001
Open
jbonnell-amd wants to merge 27 commits into
Open
Conversation
…yml to include manylinux
…-controller.yml options
jbonnell-amd
changed the title
jbonnell-amd
marked this pull request as ready for review
August 14, 2026 16:26
tomk-amd
reviewed
Aug 18, 2026
Comment on lines
-39
to
-58
| release-windows: | ||
| name: Windows Release | ||
| uses: ./.github/workflows/ci-windows.yml | ||
| secrets: inherit | ||
| with: | ||
| os_version: '[ "2022" ]' | ||
| upload_to_github: ${{ !inputs.dry_run }} | ||
| upload_to_s3: ${{ !inputs.dry_run }} | ||
| s3_root_directory: release | ||
| release_version: ${{ inputs.release_version }} | ||
|
|
||
| release-mac: | ||
| name: macOS Release | ||
| uses: ./.github/workflows/ci-mac.yml | ||
| secrets: inherit | ||
| with: | ||
| os_version: '[ "14", "15", "26" ]' | ||
| upload_to_github: ${{ !inputs.dry_run }} | ||
| upload_to_s3: ${{ !inputs.dry_run }} | ||
| s3_root_directory: release |
Collaborator
There was a problem hiding this comment.
does this mean Windows and Mac will no longer be built?
Contributor
Author
There was a problem hiding this comment.
We'll still maintain nightly uploads to the legacy S3 bucket for Windows and Mac builds (including CI checks on PRs). I've just removed the non-ManyLinux sections here to ensure that we're only building/uploading the .deb and .rpm packages from this workflow (Windows and Mac to be handled elsewhere due to signing requirements)
….yml with new options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR enables builds on ManyLinux to be published to TheRock's S3 dev environment via
release-controller.ymlas a pre-requisite for being included in the upcoming repo.amd.com releaseTechnical Details
Dockerfile.manylinuxfile which uses TheRock's manylinux image as a base, and installs extra dependencies needed by Optiq on top of it.docker-ghcr.ymlto include building and uploading of this new Docker image to Optiq's GHCRci-manylinux.ymlwhich builds Optiq on the new ManyLinux docker image, generates TGZ/RPM/DEB packages and their corresponding metadata, and uploads to the S3 bucket with the proper pathing as of the RFCci-controller.ymlto include coverage withci-manylinux.yml, which will run builds and tests on ManyLinux and upload artifacts to GitHub (only using S3 for releases now)release-controller.ymlto remove legacy uploads and only trigger aci-manylinux.ymlrun with S3 uploading to DEV environment by defaultTest Plan
Test Result
Submission Checklist