Repository navigation
Fix OpenShell evaluation Secret dependency - #108
Merged
kami619 merged 2 commits intoOct 7, 2026
Merged
Conversation
Avoid requiring a namespace inference Secret before the evaluation container can start. AI-Attribution: AIA PAI Ce Hin R gpt-6-luna v1.0 AI-Interpretation: https://aiattribution.github.io/statements/AIA-PAI-Ce-Hin-R-?model=gpt-6-luna
AI-Attribution: AIA PAI Ce Hin R gpt-6-luna v1.0 AI-Interpretation: https://aiattribution.github.io/statements/AIA-PAI-Ce-Hin-R-?model=gpt-6-luna
GuyZivRH
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OpenShell evaluation Pods failing at startup when the namespace does not contain an
inferenceSecret. The PipelineRun already passesllm-api-keyfor calls through the configured LiteLLM endpoint, so the OpenShell step should use that parameter instead of requiring a separate Kubernetes Secret.Changes
inferenceSecret from the OpenShell step'senvFromand key references.INFERENCE_API_KEYandOPENAI_API_KEYfrom$(params.llm-api-key)while keeping the OpenShell credential references.inferenceSecret references and uses the pipeline parameter for both API key variables.Test plan
rtk pytest -q tests/test_openshell_pipeline_profile.py— 5 passed.rtk ruff check tests/test_openshell_pipeline_profile.py— passed.rtk git diff --check— passed.rtk pytest -qattempted; collection is blocked in the temporary checkout becausesqlalchemyandaiohttpare not installed.Related
Fixes the missing Secret startup failure observed in the OpenShell evaluation TaskRun.
AI-Attribution: AIA PAI Nc Hin R gpt-6-luna v1.0
AI-Interpretation: https://aiattribution.github.io/statements/AIA-PAI-Nc-Hin-R-?model=gpt-6-luna