Skip to content

fix(compass): add missing rh-sre validator dependsOn/dependencyOf edges - #160

Merged
r2dedios merged 1 commit into
RHEcosystemAppEng:mainfrom
rhartuv:fix/missing-compass-dependency
Sep 16, 2026
Merged

r2dedios merged 1 commit into
RHEcosystemAppEng:mainfrom
rhartuv:fix/missing-compass-dependency

Conversation

@rhartuv

@rhartuv rhartuv commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Five rh-sre skills document a prerequisite validator in SKILL.md (/mcp-lightspeed-validator or /mcp-aap-validator) but their Compass manifests did not dependsOn those skills.
  • Added the forward dependsOn edges and matching dependencyOf inverses on the two validator manifests (COMPASS-1288).
  • Plugin MCP union, Location targets, and unregistered packs are unchanged.
  • Jira

Changes

  • cve-impact, cve-validation, fleet-inventorydependsOn mcp-lightspeed-validator
  • job-template-creator, job-template-remediation-validatordependsOn mcp-aap-validator
  • mcp-lightspeed-validator / mcp-aap-validator dependencyOf updated to include those callers

Pack(s) affected

  • ocp-admin
  • rh-ai-engineer
  • rh-automation
  • rh-basic
  • rh-developer
  • rh-sre
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)
  • uv run python scripts/validate_compass_manifests.py passes
  • Confirm no extra mcpserver: refs and no partOf/hasPart were added
  • Spot-check the seven catalog-info.yaml files: each new dependsOn has a matching dependencyOf

@rhartuv rhartuv self-assigned this Sep 15, 2026
@rhartuv
rhartuv marked this pull request as ready for review September 16, 2026 09:37

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thank you!

@r2dedios r2dedios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@r2dedios
r2dedios merged commit d912bbf into RHEcosystemAppEng:main Sep 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants