Fix coordinator schema drift and replace the synthetic test fixture - #3
Merged
Merged
Conversation
… coverage Align native maintenance with the existing reaping transition. Replace the synthetic test table with an installed-package fixture, make poll control flow explicit, and correct NULL handling and partial-load cleanup. Preserve the current CI matrices and install this checkout for the native integration test.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kafajazubtc-lang
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
changedfirst.ca_open()andca_spawn(). Cover multiple queues, exhausted versus retryable/live/terminal tasks, ownership cleanup, preserved inputs, argument validation, and the one-shot lifecycle.The schema, retry policy, public API, and runtime dependencies are unchanged. The coordinator performs maintenance; it does not dispatch jobs or execute R handlers.
Validation
Local validation on Linux with DuckDB 1.5.5:
tools/canard-coordinator/test/test-v1.Ragainst the installed package.make document,make test(1,000 results, including native coordinator and required Quack cases), andmake check(Status: OK).git diff --checkpassed.Cross-platform results are reported by this PR's GitHub checks. AddressSanitizer/UndefinedBehaviorSanitizer were not rerun for this integration.