Skip to content

Add plastic wall for HYDRA - #1335

Closed
mduer wants to merge 1 commit into
R3BRootGroup:devfrom
mduer:hydra_pw
Closed

mduer wants to merge 1 commit into
R3BRootGroup:devfrom
mduer:hydra_pw

Conversation

@mduer

@mduer mduer commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Add plastic wall for HYDRA


Checklist:

@mduer
mduer force-pushed the hydra_pw branch 3 times, most recently from 2bcba23 to c73cd70 Compare April 14, 2026 11:58
@mduer

mduer commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Pass all checks

@jose-luis-rs jose-luis-rs left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please try to include the minor changes and rebase the dev branch again.

You can also add your name to the AUTHORS file

Comment thread pw/calibration/R3BPWCal2Hit.cxx Outdated
Comment thread pw/calibration/R3BPWCal2Hit.cxx Outdated
Comment thread pw/calibration/R3BPWCal2Hit.cxx Outdated
Comment thread pw/calibration/R3BPWCal2Hit.cxx Outdated
Comment thread pw/calibration/R3BPWCal2Hit.h Outdated
Comment thread pw/online/R3BPWOnlineSpectra.h
Comment thread pw/pars/R3BPWContFact.cxx Outdated
Comment thread r3bdata/pwData/R3BPWCalData.cxx Outdated
Comment thread r3bdata/pwData/R3BPWCalData.h Outdated
Comment thread r3bsource/pw/ext_h101_pw.h
@mduer
mduer force-pushed the hydra_pw branch 3 times, most recently from 492452a to 39a9cb9 Compare April 22, 2026 11:10
@jose-luis-rs

Copy link
Copy Markdown
Contributor

After adding your name to the Author list, you must run the python scripts:
python3 update_zenodo.py
python3 update_codemeta.py
to generate the corresponding output files. Then git add "files"

Comment thread r3bdata/pwData/R3BPWWRData.cxx Outdated
@mduer

mduer commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

After adding your name to the Author list, you must run the python scripts: python3 update_zenodo.py python3 update_codemeta.py to generate the corresponding output files. Then git add "files"

I get errors for both when running them with python3 xx.. in thr R3BRoot folder. Do I need to do something in addition?

Comment thread AUTHORS Outdated
Comment thread r3bdata/pwData/R3BPWPreCalData.h Outdated
Comment thread r3bdata/pwData/R3BPWHitData.h Outdated
Comment thread r3bdata/pwData/R3BPWCalData.h Outdated
Comment thread r3bdata/pwData/R3BPWHitData.h Outdated
Comment thread r3bdata/pwData/R3BPWMappedData.h Outdated
Comment thread r3bdata/pwData/R3BPWPreCalData.h Outdated
Comment thread r3bdata/pwData/R3BPWCalData.h Outdated
Comment thread r3bdata/pwData/R3BPWCalData.h Outdated
Comment thread r3bdata/pwData/R3BPWCalData.h
Comment thread r3bdata/pwData/R3BPWCalData.h Outdated
@jose-luis-rs

Copy link
Copy Markdown
Contributor

Thanks @mduer, this PR will be merged as part of #1346 (I have rebased your changes, so you will still appear as the main author).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants