feat: exclude subpaths in feeds - #1629
Open
SnoutFirst wants to merge 2 commits into
Open
Conversation
Author
|
Replaced by #1630 to remove unrelated commits. |
SnoutFirst
force-pushed
the
exclude-subpaths-feature
branch
from
July 13, 2026 22:44
8e39feb to
83f0942
Compare
Author
|
Branch force-pushed to contain only the single relevant commit: Add excludeSubPaths feature to filter feed items by URL patterns. |
Author
|
Temporarily closing to refresh branch state after force-push. |
- Add excludeSubPaths field to feed properties dialog - Store exclusion patterns as comma-separated list in database (v18) - Filter news items at parse time based on URL patterns - Support case-insensitive partial URL matching - Useful for blocking YouTube Shorts, Facebook Reels, etc.
SnoutFirst
force-pushed
the
exclude-subpaths-feature
branch
from
July 13, 2026 22:47
83f0942 to
08465be
Compare
Commit 6bd1ae5 (cleanup: remove remaining dead webkit/embedded browser code) removed javaScriptEnable from the feed properties UPDATE query, reducing the placeholder count from 15 to 14. Commit 55ea278 (Add excludeSubPaths feature) added excludeSubPaths to the query and its bind value on a separate branch, making it 16 placeholders and 16 bind values. The merge at 402417c resolved the conflict incorrectly: it kept the left side's query (without javaScriptEnable AND without excludeSubPaths — 14 placeholders) but kept the right side's bind values (with excludeSubPaths — 15 bind values). This caused the excludeSubPaths value to be bound to the id position, and feedId to be silently ignored, meaning the UPDATE targeted the wrong row (or no row at all). The result: the disableUpdate checkbox (and any other field in the UPDATE) appeared to save but was actually updating a non-existent or wrong row, so the change was lost on next app launch. Fix: add excludeSubPaths = ? back to the UPDATE query so placeholders and bind values match. Also add the missing model update (setData) for excludeSubPaths so the in-memory model stays in sync.
Author
|
Pushed an additional fix commit (ed4f44f) that fixes a regression introduced by the merge of this branch: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a feature to exclude specific subpaths from feeds.