Remove embedded browser (webkit). QuiteRSS now only shows titles and uses external browser to display contents - #1627
Open
d3fault wants to merge 5 commits into
Open
Conversation
After the titles-only webkit removal pass, there was still quite a bit of dead code left around: AdBlock icon/manager plumbing, print/preview/save-page actions, browser back/forward/reload/position toolbar/menu items, feed description/load-images options, Click-to-Flash settings/styles, and unused HTML/CSS/image resources. Remove it all and make the news tab splitter vertical-only. Verified with a clean release build.
The previous cleanup dropped the status-bar URL message that was shown when selecting a news item. Restore it using the selected row's link directly (instead of the stale linkNewsString_ member that was part of the removed webview code).
The webkit-related qCritical("openPageInExternalBrowser") stub was already removed in the prior cleanup commit as part of deleting the dead openPageInExternalBrowser() path.
d3fault
changed the title
The titles-only cleanup changed UpdateObject::signalUpdateNews() to take no parameters, but MainWindow::slotUpdateNews() was still declared as slotUpdateNews(int refresh). Qt signal/slot connections require matching signatures, so the connection broke and the news list stopped being refreshed automatically when feeds finished updating. New items only appeared after the user switched away from and back to a category tab. Update the slot signature to slotUpdateNews(), drop the now-unused RefreshType enum, and update the three internal callers that passed NewsTabWidget::RefreshWithPos.
…anup deleted the MainWindow::slotSetValue(int) slot and\nits connection from UpdateObject::loadProgress(int). The progress bar was\nstill shown and hidden, but its value never advanced from 0%. Restore the\nslot, its declaration, and the connect() so the bar advances as each feed\nfinishes updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiles and seems to be working fine