Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
Looks good to me. I think these rules can be relaxed to not be restricted to This then also makes me trying to recall why we restricted the reverse rules? The only "array"-specific operation in most of these rules seems to be |
|
Also, these tests are currently not run. TensorOperations doesn't use ParallelTestRunners and the automatic detection stuff yet, so you have to manually include the files in runtests.jl |
|
Wait, aren't all the tests in the |
|
I think we had to redo them for the tensormaps because of the additional fermionic signs... |
|
I think the GitHub actions aren't uploading coverage data properly, I opened another PR about it |
Oh yes, I thought these were new files, and only saw the zero% PR coverage message, so I inferred that the tests did not run. |
Damn you, fermions. |
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
|
I've rebased on top of the Codecov PR, let's see if this looks a little better. Unfortunately the Enzyme code will still be uncovered... |
|
There we go, looks like the Codecov is working again |
|
@Jutho does this look good to merge ? |
|
Somehow it still seems as if none of the Enzyme changes are covered, whereas 100% of the Mooncake changes are. |
|
Yes, unfortunately due to weird lowering behaviour, the Julia coverage cannot "see" into the Enzyme rules. We see the same behaviour over at MAK. |
Added forward rules and tests. Might be nice for doing forward mode AD for TNR in the future.