Skip to content

[WIP] Implicit derivatives for CTMRG - #413

Open
leburgel wants to merge 28 commits into
mainfrom
lb/implicit
Open

[WIP] Implicit derivatives for CTMRG#413
leburgel wants to merge 28 commits into
mainfrom
lb/implicit

Conversation

@leburgel

@leburgel leburgel commented Aug 6, 2026

Copy link
Copy Markdown
Member

Adds implicit gradients for CTMRG contractions.

Reference: https://arxiv.org/abs/2607.15030

@leburgel
leburgel marked this pull request as draft August 6, 2026 14:57
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.56743% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...hms/contractions/ctmrg/characteristic_equations.jl 87.13% 35 Missing ⚠️
...lgorithms/optimization/implicit_differentiation.jl 94.91% 6 Missing ⚠️
Files with missing lines Coverage Δ
src/Defaults.jl 85.71% <ø> (ø)
src/algorithms/ctmrg/c4v.jl 83.48% <100.00%> (-0.45%) ⬇️
src/algorithms/ctmrg/sequential.jl 98.43% <100.00%> (+0.02%) ⬆️
src/algorithms/optimization/peps_optimization.jl 94.73% <ø> (ø)
...lgorithms/optimization/implicit_differentiation.jl 91.77% <94.91%> (ø)
...hms/contractions/ctmrg/characteristic_equations.jl 87.13% <87.13%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leburgel leburgel added the documentation Improvements or additions to documentation label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

After the build completes, the updated documentation will be available here

@leburgel
leburgel marked this pull request as ready for review August 10, 2026 14:26
@leburgel
leburgel requested review from lkdvos and pbrehmer August 10, 2026 14:27
Comment thread src/algorithms/contractions/ctmrg/characteristic_equations.jl
Comment thread src/algorithms/contractions/ctmrg/characteristic_equations.jl
Comment thread src/algorithms/contractions/ctmrg/characteristic_equations.jl Outdated
Comment thread src/algorithms/contractions/ctmrg/characteristic_equations.jl Outdated
Comment thread src/algorithms/contractions/ctmrg/characteristic_equations.jl Outdated
Comment thread src/algorithms/optimization/implicit_differentiation.jl Outdated
Comment thread src/algorithms/optimization/implicit_differentiation.jl
Comment thread src/algorithms/optimization/implicit_differentiation.jl Outdated
Comment thread src/algorithms/optimization/implicit_differentiation.jl Outdated

@pbrehmer pbrehmer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me! I would personally like to give SequentialCTMRG with implicit differentiation a try but we can of course also postpone this to a later PR.

Comment thread src/algorithms/contractions/ctmrg/characteristic_equations.jl
Comment thread src/algorithms/optimization/implicit_differentiation.jl
Comment thread src/algorithms/optimization/implicit_differentiation.jl
@leburgel

Copy link
Copy Markdown
Member Author

Windows CI is completely refusing to work for some reason, but other than that I think this has pretty much everything I had in mind for now.

@leburgel
leburgel requested review from lkdvos and pbrehmer August 19, 2026 08:09

@pbrehmer pbrehmer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge to me now! The Windows CI problems look like they are not really related to this PR in particular and rather some CI setup issue, if I'm not mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants