Skip to content

PCVL-1242 photon error mitigation - #778

Merged
Aubaert merged 13 commits into
Quandela:developfrom
Aubaert:PCVL-1242-photon-error-mitigation
Jul 31, 2026
Merged

PCVL-1242 photon error mitigation#778
Aubaert merged 13 commits into
Quandela:developfrom
Aubaert:PCVL-1242-photon-error-mitigation

Conversation

@Aubaert

@Aubaert Aubaert commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Aubaert
Aubaert marked this pull request as ready for review July 31, 2026 12:10
from .photon_recycling import photon_recycling, PhotonRecycling
from .abstract_mitigation import AbstractMitigation
from .compilation_averaging import CompilationAveraging
from .photon_error_mitigation import PhotonErrorMitigation No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

return results[0]

sub_comps = self.extend_computation(computation, noise)
sub_parameters = [comp.parameters for comp in sub_comps]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems unused

else:
p2 = 0

# The loss is not exactly this product, but this will be enough for now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loss value is accurate enough for our needs

computation = Computation(c.get_command("probs"), e)

perfect_res = c.execute(computation)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test showing that unmitigated results are not close to perfect results?

@Aubaert
Aubaert merged commit 148baff into Quandela:develop Jul 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants