Skip to content

feat(chat): open the settings window from the view header - #65

Merged
luoxuanzao merged 2 commits into
mainfrom
feat/header-settings-button
Sep 16, 2026
Merged

luoxuanzao merged 2 commits into
mainfrom
feat/header-settings-button

Conversation

@luoxuanzao

Copy link
Copy Markdown
Member

Summary

  • Add a gear button beside the feedback button in the view header that opens the Qoderian settings page in its own window, so reaching a setting no longer means diving into Obsidian's settings pane and the sidebar/chat stay in place.
  • The settings window renders through a new mount(containerEl) entry point that shares the existing imperative builders with the pre-1.13 display() fallback; PluginSettingTab.display() (deprecated since Obsidian 1.13.0) is no longer called anywhere, and the tab keeps its declarative getSettingDefinitions() for 1.13+.
  • Adds the settings window styles, a unit test for the modal, and a changelog entry.

Verification

  • npm run typecheck
  • npm run lint
  • npm run test — 165 suites / 3538 tests pass
  • Live check in the dev vault (built + window reloaded): the header shows the gear button, clicking it opens the settings window with all 29 setting rows, Esc closes it
  • src contains no remaining .display() calls

Safety

  • No credentials, private vault content, internal URLs, or personal paths are included
  • User-visible changes are documented in CHANGELOG.md

Co-authored-by: QoderAI (Qwen 3.8 Max) qoder_ai@qoder.com

luoxuanzao and others added 2 commits September 16, 2026 08:48
Reaching a Qoderian setting meant diving into Obsidian's settings pane.
Put a gear button beside the feedback button in the view header that opens
the settings page in its own window, so the sidebar and chat stay in place.

Co-authored-by: QoderAI <qoder_ai@qoder.com>
…lay()

The header settings window called PluginSettingTab.display(), which is
deprecated since Obsidian 1.13.0. Add a mount(container) entry point that
shares the existing imperative renderer with the pre-1.13 display() fallback
that Obsidian still owns.

Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>
@luoxuanzao
luoxuanzao merged commit 88623f5 into main Sep 16, 2026
10 checks passed
@luoxuanzao
luoxuanzao deleted the feat/header-settings-button branch September 16, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant