feat(chat): open the settings window from the view header - #65
Merged
Merged
Conversation
Reaching a Qoderian setting meant diving into Obsidian's settings pane. Put a gear button beside the feedback button in the view header that opens the settings page in its own window, so the sidebar and chat stay in place. Co-authored-by: QoderAI <qoder_ai@qoder.com>
…lay() The header settings window called PluginSettingTab.display(), which is deprecated since Obsidian 1.13.0. Add a mount(container) entry point that shares the existing imperative renderer with the pre-1.13 display() fallback that Obsidian still owns. Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mount(containerEl)entry point that shares the existing imperative builders with the pre-1.13display()fallback;PluginSettingTab.display()(deprecated since Obsidian 1.13.0) is no longer called anywhere, and the tab keeps its declarativegetSettingDefinitions()for 1.13+.Verification
npm run typechecknpm run lintnpm run test— 165 suites / 3538 tests passsrccontains no remaining.display()callsSafety
CHANGELOG.mdCo-authored-by: QoderAI (Qwen 3.8 Max) qoder_ai@qoder.com