Repository navigation
feat(items): add diamond and 10kgoldchain for qbx_pawnshop - #144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qbx_pawnshop's default melting rewards give
diamond(from diamond_ring, rolex and 10kgoldchain) and its sell and melt lists include10kgoldchain, but neither item is defined here, soAddItemfails when melted items are picked up (Qbox-project/qbx_pawnshop#15, fixed on the resource side in Qbox-project/qbx_pawnshop#19).Adds both with the same weight as the other jewelry items, and gives
diamond_ringits own label instead of "Diamond" so the two items can be told apart. qbx_invimages has10kgoldchain.pngbut nodiamond.pngyet, so the diamond shows without an icon until one is added.