Expand Python/Colab demos to explicitly cover concave, holes, and 2D partition workflows - #6
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update demo to showcase key features of implicit-spline technique
Expand Python/Colab demos to explicitly cover concave, holes, and 2D partition workflows
Jul 16, 2026
QL-UoHull
marked this pull request as ready for review
July 16, 2026 15:31
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the Python demo script and Colab-visible notebook to explicitly showcase additional implicit-spline workflows beyond convex polygons—specifically concave/freeform polygons, polygons with holes, and multi-polygon 2D partition visualizations—while updating the examples README to improve discoverability.
Changes:
- Restructures
examples/demo.pyinto four feature-focused sections and adds explicit concave/freeform polygon figures plus clearer holes/partition sequencing. - Extends
notebooks/01_basic_polygon.ipynbwith runnable concave, holes, and 2D partition sections and updates imports accordingly. - Updates
examples/README.mdto reflect the expanded demo/notebook coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| notebooks/01_basic_polygon.ipynb | Adds concave, holes, and partition demo sections and visualization helpers for Colab-visible execution. |
| examples/README.md | Updates the examples feature map and notebook description to surface concave/holes/partition demos. |
| examples/demo.py | Reorganizes the standalone demo into explicit feature categories and adds concave polygon + panel examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+283
to
+284
| "The method can still be used for concave control polygons. This section makes the\n", | ||
| "concave case explicit and shows paper-style contour evolution with varying $\\delta$." |
Comment on lines
+170
to
+173
| print("Category 2: concave / freeform polygons") | ||
|
|
||
| # Example 7: Triangle with inner triangular hole | ||
| print(" Example 7: triangle with a hole") | ||
| # Example 7: Concave polygon ("arrowhead") | ||
| print(" Example 7: concave polygon") |
| - multi-panel contour evolution under increasing `delta`, | ||
| - freeform curve design from hand-crafted control polygons, and | ||
| - 3D wireframe surface views of summed polygon basis functions. | ||
| - freeform / concave curve design from hand-crafted polygons, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current PR still read as mostly single-convex-polygon plotting in Colab/demo flows. This update makes the key implicit-spline use cases explicit and discoverable: convex evolution, concave/freeform polygons, polygons with holes, and multi-polygon 2D partitions.
Demo restructuring (
examples/demo.py)deltadeltaevolution panelColab-visible notebook coverage (
notebooks/01_basic_polygon.ipynb)Example discoverability docs (
examples/README.md)Example of the new explicit concave panel call: