Integrate paper-style examples and repair 01_basic_polygon.ipynb plotting/runtime path - #4
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update examples with enhanced paper-style visuals and notebook fixes
Integrate paper-style examples and repair Jul 16, 2026
01_basic_polygon.ipynb plotting/runtime path
QL-UoHull
marked this pull request as ready for review
July 16, 2026 14:09
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the project’s Python examples to better match the multi-panel / paper-style figures from Li & Tian (2009), and fixes reliability issues in the basic notebook (notably 3D plotting axes and local import-path handling) so it runs consistently in common environments (Colab, repo root, notebooks/).
Changes:
- Extend
examples/demo.pyfrom the original 4 examples to a larger “paper-style” set (delta panels, smoothness-order comparison, freeform gallery, partition/summed-basis surfaces, and an extra wireframe surface view). - Add/extend reusable visualization helpers (e.g.,
compare_n,panel_delta_shapes,partition_basis_surfaces, anddraw_surfacewireframe/view controls) to support these richer figures. - Repair
notebooks/01_basic_polygon.ipynbexecution by making surface plotting explicitly 3D-safe and making local imports more robust.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| notebooks/01_basic_polygon.ipynb | Fixes runtime reliability (robust sys.path setup) and corrects surface plotting by using explicit 3D axes; adopts helper-based smoothness comparison. |
| examples/demo.py | Expands the standalone demo into a richer, paper-style set of examples and uses shared plotting helpers for consistent figures. |
| python/implicit_spline/visualization.py | Provides/extends plotting helper functions needed by the new demo/notebook (including compare_n, multi-panel contour helpers, and 3D surface options). |
| examples/README.md | Updates examples documentation to reflect the expanded demo and paper-style figure capabilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes the
copilot/paper-style-examplesupdates intomain: richer, paper-style example outputs and a notebook reliability fix. It expands the examples surface/contour story and resolves the01_basic_polygon.ipynbexecution issues (3D plotting + local import-path handling).examples/demo.py: paper-style example expansiondeltaevolution, smoothness-order (n) comparison, freeform curve gallery, partition/summed-basis surfaces, and an additional wireframe surface view.python/implicit_spline/visualization.py: reusable plotting helpers for advanced figuresnotebooks/01_basic_polygon.ipynb: execution and plotting repairexamples/README.md: examples documentation refresh