Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Bug fix with regression tests and a release note.
Motivation and context / Related issue
Fitting a domain-adaptation estimator with CUDA integer labels fails while
forming the label-presence mask:
The same failure occurs with int32 labels. Replace the
(ns, 1) @ (1, nt)matrix product with a broadcast product. Both compute the same outer product;
broadcast multiplication supports these integer types without changing dtype
or device. Missing-label behavior stays the same.
How has this been tested (if it applies)
and without missing source/target labels. Four CPU controls pass throughout.
python -m pytest test/test_da.py -q: 59 passed, 2 skipped.pre-commit run --all-files: passes.python -m pytest --durations=20 -q test/ --doctest-modules --maxfail=3: 2,705 passed, 62 skipped, 6 xfailed (NumPy and PyTorch backends, 235 seconds).On actual Iris, Wine and handwritten-digit records, all 48 integer CUDA
EMD/Sinkhorn workflows now complete. Transport, barycentric mapping, propagated
label probabilities and downstream classifier predictions exactly match the
floating-label CUDA controls. The 48 CPU integer control records and 48 CUDA
floating control records are unchanged by the patch. Independently formed costs
and SciPy assignment objectives agree within 2.89e-15 and 2.78e-17 respectively.
This checks execution and equivalence, not classification accuracy. Validated on
Linux with torch 2.7.0+cu128 and an RTX 5070.
PR checklist