Skip to content

change simpleyaml group - #1364

Closed
TheRealRyGuy wants to merge 1 commit into
PurpurMC:ver/1.20.1from
TheRealRyGuy:fix/simpleyaml
Closed

TheRealRyGuy wants to merge 1 commit into
PurpurMC:ver/1.20.1from
TheRealRyGuy:fix/simpleyaml

Conversation

@TheRealRyGuy

@TheRealRyGuy TheRealRyGuy commented Jun 24, 2023 •

Copy link
Copy Markdown
Contributor

i'll eventually pr this to pufferfish as well but my workspace is struggling rn
something about the jitpack on this lib is goofed
https://jitpack.io/com/github/carleslc/Simple-YAML/Simple-Yaml/1.8.4/Simple-Yaml-1.8.4.pom exists
https://jitpack.io/me/carleslc/Simple-YAML/Simple-Yaml/1.8.4/Simple-Yaml-1.8.4.pom doesn't
this should let people build locally nicer
yaml issue - Carleslc/Simple-YAML#77

@BillyGalbreath

Copy link
Copy Markdown
Contributor

Purpur doesn't add this dependency. You need to PR this upstream to the project that does, Pufferfish. If it is a valid concern, they will use it. If not, they will explain why it isn't.

@TheRealRyGuy

TheRealRyGuy commented Jun 24, 2023 •

Copy link
Copy Markdown
Contributor Author

pufferfish-gg/Pufferfish#73 - did it here too as well just for expediency, in my mind was just a game of who does it first

@granny

granny commented Jun 25, 2023

Copy link
Copy Markdown
Member

superceded by 07dbb3d

@granny granny closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants