fix: remove redundant shells from generate_completions_from_executable template#1652
Merged
Merged
Conversation
…e template Homebrew's FormulaAudit/RedundantGenerateCompletionsShells audit now flags the explicit shells: [:bash, :fish, :zsh] argument as redundant, since those are the defaults. Remove the shells: parameter from the generate_completions_from_executable call in the formula template so generated formulas pass this audit cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew's
FormulaAudit/RedundantGenerateCompletionsShellsaudit now flags the explicitshells: [:bash, :fish, :zsh]argument togenerate_completions_from_executableas redundant, because those are already the defaults.This removes the
shells:parameter from thegenerate_completions_from_executablecall inhomebrew/formula.rb.j2so that formulas generated from this template pass the audit cleanly.Changes
homebrew/formula.rb.j2: simplifiedThe resulting completions behavior is unchanged, since bash, fish, and zsh are the default shells.