Repository navigation
Fix dev server directory events and output cleanup races. - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix dev server directory events and output cleanup races
Changes
Directory watcher events could trigger an attempt to delete an output directory as a file, causing
EISDIR. The resulting setup reset could then remove HTML while a request was reading it, causingENOENT.Ignore existing directory notifications, refresh discovery for removed subtrees, and invalidate only known asset files. Setup resets now wait for active responses to finish, while new requests wait until setup completes. Normal requests remain parallel.
Validation