Skip to content

Don't panic syncing a browser pane whose navigation failed #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanclouser merged 1 commit into from
Oct 3, 2026
Merged

Don't panic syncing a browser pane whose navigation failed #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion crates/muxel/src/browser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,19 @@ mod imp {
}
}

#[cfg(target_os = "macos")]
fn committed_url(webview: &wry::WebView) -> Option<String> {
use wry::WebViewExtMacOS as _;
let url = unsafe { webview.webview().URL() }?;
url.absoluteString()?;
webview.url().ok()
}

#[cfg(target_os = "windows")]
fn committed_url(webview: &wry::WebView) -> Option<String> {
webview.url().ok()
}

/// IPC message the page posts when it is clicked. Namespaced so it can't
/// collide with a site that uses `window.ipc` for its own purposes.
#[cfg(target_os = "macos")]
Expand Down Expand Up @@ -562,7 +575,7 @@ mod imp {
/// tick so `Instance.browser_url` and the address bar stay fresh.
pub fn sync(&mut self, window: &mut Window, cx: &mut Context<Self>) -> Option<String> {
let wv = self.webview.as_ref()?;
let current = wv.read(cx).url().ok()?;
let current = committed_url(wv.read(cx).raw())?;
// A newly created WebView2 reports its bootstrap document before
// the requested navigation commits. Persisting that transient URL
// loses the resource identity and lets a fast second click create
Expand Down
Loading