Bug #15705: Accession register - filter issues - #3901
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe multi-input component now supports cancellation by clearing its control while editing. It no longer updates ChangesEditable field and component imports
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This is a localized filter behavior fix with no actionable merge-blocking risk remaining beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
hazco75
added
the
small
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ui/ui-frontend/projects/vitamui-library/src/app/modules/components/editable-field/editable-field.component.ts`:
- Line 202: Restore EditableFieldComponent.cancel() to reset control with
this.originValue, preserving the base cancellation contract and existing tests.
If VitamuiMultiInputsComponent requires a blank editor after cancellation,
override cancel() there to perform that component-specific reset instead.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 88b22f3a-81b6-4238-9d4d-1f0cef3f5b51
📒 Files selected for processing (2)
ui/ui-frontend/projects/vitamui-library/src/app/modules/components/editable-field/editable-field.component.tsui/ui-frontend/projects/vitamui-library/src/app/modules/components/vitamui-multi-inputs/vitamui-multi-inputs.component.ts
Collaborator
|
New Issues (12)Checkmarx found the following issues in this Pull Request
Fixed Issues (398)Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
hazco75
force-pushed
the
bug_15705_accession_register
branch
from
August 11, 2026 12:32
8f5263c to
6c5f89f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ui/ui-frontend/projects/vitamui-library/src/app/modules/components/vitamui-multi-inputs/vitamui-multi-inputs.component.ts`:
- Around line 121-124: Update vitamuim-multi-inputs component’s cancel()
override to reset this.control only when the component is in edit mode,
preserving EditableFieldComponent.cancel()’s inactive-mode behavior and
preventing Escape or direct cancel() calls from clearing the value outside edit
mode.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b59b6920-21fe-435e-a0e5-02400d3952ae
📒 Files selected for processing (2)
ui/ui-frontend/projects/vitamui-library/src/app/modules/components/editable-field/editable-field.component.tsui/ui-frontend/projects/vitamui-library/src/app/modules/components/vitamui-multi-inputs/vitamui-multi-inputs.component.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- ui/ui-frontend/projects/vitamui-library/src/app/modules/components/editable-field/editable-field.component.ts
hazco75
force-pushed
the
bug_15705_accession_register
branch
from
August 11, 2026 12:45
6c5f89f to
e22ed1c
Compare
hazco75
force-pushed
the
bug_15705_accession_register
branch
2 times, most recently
from
August 13, 2026 16:26
781246c to
f32cf72
Compare
hazco75
force-pushed
the
bug_15705_accession_register
branch
from
August 13, 2026 16:37
f32cf72 to
512faae
Compare
marob
approved these changes
Aug 13, 2026
mkhediri
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problème de filtre sur le registre des fonds : cliquer sur X pour supprimer le contenu de l'input affiche les valeurs déjà ajoutées à ce même input + clean code
Summary by CodeRabbit