fix: delete omitted quotas and questions when the same edit adds new ones - #69
Merged
Merged
Conversation
…ones The admin form sends kept rows with ids and new rows with a null id. update_event_quotas and update_event_questions detect removals with `id not in (select id from unnest(input))`, and NOT IN never evaluates true against a set containing null — so one new row in the input silently disabled deletion for the whole call. Exclude nulls from the comparison set. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📦 Next.js Bundle Analysis for @app/clientThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin form sends kept rows with ids and new rows with a null id.
update_event_quotas and update_event_questions detect removals with
id not in (select id from unnest(input)), and NOT IN never evaluatestrue against a set containing null — so one new row in the input
silently disabled deletion for the whole call. Exclude nulls from the
comparison set.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com