Skip to content

CPU topology v2 phase 2: add topology provider abstraction#8

Merged
PrimeBuild-pc merged 2 commits into
mainfrom
codex-cpu-topology-v2-phase-2
May 19, 2026
Merged

CPU topology v2 phase 2: add topology provider abstraction#8
PrimeBuild-pc merged 2 commits into
mainfrom
codex-cpu-topology-v2-phase-2

Conversation

@PrimeBuild-pc
Copy link
Copy Markdown
Owner

Summary

  • Adds ICpuTopologyProvider as a testable topology snapshot abstraction.
  • Adds WindowsCpuTopologyProvider backed by GetSystemCpuSetInformation and GetLogicalProcessorInformationEx for CPU Set IDs, processor groups, group-relative logical processor numbers, global indexes, core indexes, efficiency classes, NUMA nodes, L3/cache groups, packages, and SMT sibling metadata.
  • Extends CpuTopologySnapshot with optional topology metadata while preserving the legacy affinity-mask conversion model from phase 1.
  • Adds fake-provider and simulated topology tests for single-group, multi-group, hybrid efficiency classes, SMT on/off, dual L3 groups, and >64 logical processors.

Validation

  • dotnet test "ThreadPilot_1.sln" --configuration Release --no-restore passes: 173 passed, 0 failed.

Scope intentionally left unchanged

  • No runtime affinity application changes.
  • No ProcessService or ProcessCpuSetHandler behavior changes.
  • No UI changes.
  • No preset generator changes.
  • No profile or legacy-mask persistence changes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 30.91603% with 181 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Services/WindowsCpuTopologyProvider.cs 0.00% 172 Missing ⚠️
Services/WindowsCpuTopologyNativeLayout.cs 81.08% 5 Missing and 2 partials ⚠️
Models/CpuSelection.cs 96.22% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@PrimeBuild-pc PrimeBuild-pc merged commit ff1cd97 into main May 19, 2026
3 checks passed
@PrimeBuild-pc PrimeBuild-pc deleted the codex-cpu-topology-v2-phase-2 branch May 19, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants