Repository navigation
Bundle Node 24.22.1 (Node security release 2026-10-20) - #36
Merged
Merged
Conversation
aharlap
marked this pull request as ready for review
October 22, 2026 00:20
aharlap
marked this pull request as draft
October 22, 2026 00:30
Contributor
Author
|
On hold: Node 24.22.1 disables fsync when the Permission Model is on (ERR_ACCESS_DENIED). Studio's CLI, which Rubato runs on this bundled Node, fsyncs under --permission, so lesson saves would fail. Waiting for the Studio fix before merging. |
Doctor only runs read-only inspect, so a Node change that breaks Studio's durable writes (fsync) would pass. identity init writes through the journal and flush path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aharlap
marked this pull request as ready for review
October 22, 2026 04:06
identity init refuses a folder without course.yaml. Copy the fixture course's manifest and lesson, without its .praxity identity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the shared bundled Node runtime to 24.22.1 for the 2026-10-20 Node security release. Update all four runtime URLs and SHA-256 pins, preserved provenance, README, both CI Node versions, the package engine floor, and current-pin tests and fixtures. Historical shipped-manifest fixtures and their signed checksum evidence are unchanged.
Verification used the existing public key in
docs/provenance/node-release-key.asc, with WSL Ubuntu-24.04 GnuPG 2.4.4 and a fresh scratch keyring:GOODSIGandVALIDSIGconfirmed the recorded fingerprint5BE8A3F6C8A5C01D106C0AD820B1A390B168D356. No new key was trusted. The verified cleartext and signed list are preserved indocs/provenance/node-v24.22.1-SHASUMS256.txtand.txt.asc.Each filename was read from the verified list, downloaded from the official version directory with
curl.exe --fail --location --output <file> <url>, and checked withGet-FileHash -LiteralPath <file> -Algorithm SHA256against its signed entry:89c682593d76cd44233fa53b1563264e7de9cbb189cad169135c5b4fadfbc0a7, 53,062,778 bytes.d132557e7ee2b85af08b0c8c34338e65c6430f2238d01f727728ef42dc83b035, 54,382,566 bytes.eb6728e77c576a35162c122c45ccadf224d89ff00abc8dae46cc2897c6002d7c, 58,290,700 bytes.d2046d28c2c3dcd211ac5145c0bf30e2047ef9dfb306693c8c6e2eccd8b95fa5, 37,748,064 bytes.The manifest does not carry archive sizes, so no size fields were added.
Checks, using Node 24.22.1 extracted from the verified Windows and Linux archives:
npm.cmd run validate: passed.npm.cmd run validate:release: passed; validation only, no publishing.node --test test/manifest.test.mjs test/skills.test.mjs test/ci-manifest.test.mjs: 107 passed on Windows.node --test test/install-launcher.test.mjs test/install.test.mjs: 37 passed in WSL Ubuntu-24.04 withTMPDIR=/tmp.TMPDIR=/tmp, 2/2 tests. No acceptance checks were relaxed.git diff --check: passed.Ubuntu and both native macOS CI jobs remain the full integration gate.
Studio write smoke (added after Studio #1864): Node 24.22 blocks fsync under the Permission Model. Rubato launches tools without
--permission, so installs are unaffected, but the doctor only runs read-onlyinspect. The macOS real-install job now runspraxity identity initon a fresh course and checks the output and.praxity/identity/course.json.Review: 0/0/0; fixes 0. Opus controller review; hashes rechecked against nodejs.org SHASUMS256.txt, signed file identical.
🤖 Generated with Claude Code