Repository navigation
Remove unused exports and duplicate tests (simplify audit) - #35
Merged
Merged
Conversation
The rewrite removed every mutant assertion, not just the source-count check. Each mutant proves a stop case is caught by the rule it names, not by another guard, so dropping them loses coverage. The rename fragility is the cost of that proof. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five findings from a simplify audit, no runtime change.
quotePosiximport insrc/cli.mjs.exportonofficialReleaseChannel(src/update.mjs) andverifyStudioArchive(scripts/publish-studio-pack.mjs). Both stay, with their checks.test/studio-annotation.test.mjs(the null row at line 56 covers it).missing x64publisher row; "isolated refusal: missing archive" covers it and also checks the error message.Not applied: rewriting the assessment gate's mutation tests. The rewrite removed every mutant assertion. Each mutant proves a stop case is caught by the rule it names, not by another guard, so removing them loses coverage. Breaking on a variable rename is the cost of that proof.
Checks:
npm.cmd run validatepassed; changed test files pass on Windows (Node 24.19.0) and WSL (Node 24.18.0);test/assessment-writing.test.mjsback to main, 26 passed. CI on Ubuntu and macOS is the full gate.Review: 1/0/0 0/0/0; fixes 1. Opus controller review: the assessment test rewrite dropped all mutation coverage, reverted; recheck clean.
🤖 Generated with Claude Code