Repository navigation
docs(reload-feature-flags): document optional completion failure reporting and iOS 4.0 signature - #99
Merged
Merged
Conversation
…rting and iOS 4.0 signature Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 6, 2026
turnipdabeets
marked this pull request as ready for review
October 6, 2026 22:22
dustinbyrne
approved these changes
Oct 6, 2026
dustinbyrne
left a comment
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. The documented iOS signature and request-specific failure behavior match the companion implementation. Two non-blocking wording suggestions inline.
AI-assisted review.
…t cached values Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
posthog-ios 4.0 (PostHog/posthog-ios#913) passes a
PostHogFeatureFlagsLoaded(flags,variants,errorsLoading) to thereloadFeatureFlags(_:)callback, so callers can tell a failed reload from a successful one. This spec still lists the zero-argument iOS callback, and says failure reporting is SDK-specific without saying what a reported failure must mean.Draft until posthog-ios 4.0 ships.
What changes
(PostHogFeatureFlagsLoaded) -> Void(4.0+).onFeatureFlags.No SDK is required to change. The canonical
(flags?, error?: Error)signature is unchanged; reconciling it with theerrorsLoadingshape is a separate cross-SDK decision. Quota-limited and partial responses stay SDK-specific (iOS and posthog-js treat them as non-failures since they return 200).Why a requirement rather than a narrative-only edit: OpenSpec rejects a change with no requirement delta, and the optional (MAY) form binds no SDK that doesn't expose a failure signal.
Validation
openspec validate --specs --strict: 64 passed. The change passed strict validation before archiving.git diff --checkclean.Related: PostHog/posthog-ios#913, PostHog/posthog-flutter#643.
🤖 Generated with Claude Code