Repository navigation
fix(session-replay-debug-properties): follow capture's property precedence - #155
Merged
Merged
Conversation
…dence Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dustinbyrne
approved these changes
Oct 28, 2026
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
This aligns replay-debug property precedence with capture’s existing contract, with synchronized archived requirements and scenarios for registered, caller, and event-local overrides. No actionable findings.
AI-assisted review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #143. That PR gave client SDKs one property order with no exceptions (SDK-set, then registered, then caller, then
before_send), and named the replay debug properties among the keys that move under it. Butsession-replay-debug-propertiesstill says SDK-computed$recording_statusand$sdk_debug_*values win over a registered or caller property and that the debug map is merged last, so the two specs disagree. The PostHog review bot flagged the conflict on PostHog/posthog-ios#938.Changes
before_sendcan change any of them, and the override applies to that event only.openspec validate --specs --strictpasses (67/67). No acceptance feature covers these keys.Impact
@posthog/core: no work beyond what fix(capture): one property precedence for client SDKs #143 already lists for them (setting the replay debug properties before super and caller properties).🤖 Generated with Claude Code