Repository navigation
docs(setup): record React Native's projectToken adoption - #152
Draft
posthog[bot] wants to merge 2 commits into
Draft
posthog[bot] wants to merge 2 commits into
posthog[bot] wants to merge 2 commits into
Conversation
posthog-android ran the hook chain twice per stateful capture, and posthog-rust merged groups and trimmed minimized $feature_flag_called events after the hook. Both now match posthog-ios and posthog-python. Specify the single invocation and the event shape the hook sees. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 4237a2aa-9610-4c4f-a024-1ae7a64b0d75
posthog-js added a projectToken prop to PostHogProvider and deprecated apiKey, so the spec's note that React Native has not adopted the name is out of date. Unity remains the one client SDK still on ApiKey. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 4237a2aa-9610-4c4f-a024-1ae7a64b0d75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
setupspec's descriptive prose says two client SDKs have not adopted theprojectTokenname, naming React Native'sPostHogProviderapiKeyprop. posthog-js#5436 implemented the spec's "Project token configuration option name" and "Deprecated project credential alias" requirements for React Native:PostHogProvidernow takesprojectToken,apiKeyis kept as a@deprecatedalias in the same release, andprojectTokenwins when both are set. The spec's status note is now wrong.What changed
Prose only, in the non-normative "Surface variants" section:
projectToken, with the deprecatedapiKeyalias noted.new PostHog(projectToken, options?), matching the renamed parameter. The spec's point that a positional parameter's name is not part of the contract is unchanged.No requirement text changes, so there is no OpenSpec delta to propose and archive — this is a factual correction to an SDK-status note, not a contract change. Happy to wrap it in a change directory if you'd rather every edit under
openspec/specs/carry one.Not covered
compliance/posthog-react-native.mdstill carries the old "Downgraded on new spec text" finding for this row. The weekly compliance audit owns those files, so this PR leaves them alone.Created with PostHog Desktop
🤖 Generated with Claude Code