Skip to content

fix(desktop): dismiss mission control overlay on focus - #81585

Draft
adboio wants to merge 1 commit into
masterfrom
posthog/fix-mission-control-overlay-focus
Draft

fix(desktop): dismiss mission control overlay on focus#81585
adboio wants to merge 1 commit into
masterfrom
posthog/fix-mission-control-overlay-focus

Conversation

@adboio

@adboio adboio commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Problem

Returning to PostHog Code from Mission Control can leave the overlay visible for up to 250 ms.

Why: The delayed dismissal makes the app feel unresponsive when users resume work.

Changes

  • The app samples Mission Control state immediately when its window regains focus.
  • Polling remains as the entry detector because macOS exposes no reliable public Mission Control enter or exit notification.
  • No screenshot: the overlay appearance is unchanged.

How did you test this code?

  • Added a regression test that verifies focus-driven refresh dismisses the overlay before the next poll.
  • Ran the focused Mission Control test suite, Code typecheck, and Biome checks.
  • Not tested manually on macOS in this Linux environment.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Automatic notifications

  • Publish to changelog?

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Codex implemented and verified this change through PostHog Desktop. Skills invoked: /i-have-adhd, /posthog-desktop, and /writing-pr-descriptions.

No private session material appears in the public artifacts.


Created with PostHog Desktop

Generated-By: PostHog Desktop
Task-Id: 1d0e5295-ca32-442b-bbf4-913983864140
@adboio adboio self-assigned this Aug 11, 2026
@trunk-io

trunk-io Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merging to master in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

Copy link
Copy Markdown
Contributor

Hey @adboio! 👋

It looks like your git author email on this PR isn't your @posthog.com address (adambowker98@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

@github-actions github-actions Bot added the feature/desktop Feature Tag: Desktop label Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit f9b829f.

@trunk-io

trunk-io Bot commented Aug 11, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/desktop Feature Tag: Desktop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant