Repository navigation
fix(cdp): pass reply-to to the local maildev transport - #121872
Conversation
The SES path already sets ReplyToAddresses. The local MailDev path dropped reply-to, so a reply-to never showed up when testing emails on a dev stack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 90d9a51d-beba-47ba-8f50-b351327676f9
|
😎 Merged successfully - details. |
🤖 CI report✅ Trunk lane — non-backend laneThis PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes. ✅ Duplication (Python) — cleanNew Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. ✅ Duplication (TypeScript) — cleanNew TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. |
|
|
|
Risk: No findings Dev-only change: the local MailDev email transport now forwards the parsed reply-to addresses to nodemailer, matching what the production SES path already does. The transport only exists in dev/test environments and reuses the same parseAddressList value the SES path already accepts, so no new attack surface is introduced. Sentinel reviewed |
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved.
Contained development/test transport fix with no production delivery changes or open substantive review concerns. The reported duplicate-email test failure is not explained by this diff, which adds no additional send operation.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 4L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (4L, 1F, single-area, fix) |
| stamphog 2.6.0 | .stamphog/policy.yml @ ab097e4 · reviewed head ab097e4 |
|
/trunk merge |
Problem
ReplyToAddresses. Only the dev-only MailDev transport dropped it.Changes
How did you test this code?
Sent a transactional email with a reply-to on a local stack. MailDev received
Reply-To: security@posthog.com, which was missing before.Test rationale: No new test. The change is a dev-only transport that unit tests don't exercise, and the manual send above covers it.
Release status
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: PostHog Desktop with Claude Code, Claude Opus 5.5 (
claude-opus-5-5)Created with PostHog Desktop
🤖 Generated with Claude Code