Repository navigation
fix(tasks): stop retrying a repository clone that github denies - #120729
trunk-io[bot] merged 1 commit into
Conversation
A clone that GitHub rejects for access (no usable token, or a token that does not cover the repository) now raises a non-retryable RepositoryAccessError. The error is not captured to error tracking and tells the person to check the GitHub app's repository access. Network and other clone failures keep the transient RepositoryCloneError and its retries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 30c2fa20-55cd-4b80-b050-204eef23ea82
|
😎 Merged successfully - details. |
|
Risk: No findings This change stops retrying sandbox repository clones when git's output shows GitHub denied access: a new fatal, non-reportable Sentinel reviewed |
🤖 CI report
|
There was a problem hiding this comment.
Approved.
The access-denial handling has current-head independent assurance from PostHog Review (Standard), and no unresolved concerns were supplied or found. The verified Inbox provenance exempts this machine author from the bot-author refusal rule.
- PostHog Review (Standard) reviewed the current head: no findings.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 39L, 2F substantive, 99L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (99L, 3F, single-area, fix) |
| stamphog 2.6.0 | .stamphog/policy.yml @ b68b80f · reviewed head b68b80f |
Problem
RepositoryCloneError. Access denials make up most of the RepositoryCloneError issue since fix(tasks): stop a run planning when it has no repository checkout #117823 merged. That PR's.gitguard works as intended. It now fails these runs that were already broken.Origin
signals-scout-inbox-validationChanges
RepositoryAccessErroris non-retryable and aNonReportableError, the same contract asCredentialUnavailableError. It does not reach error tracking.RepositoryCloneErrorand its three retries.How did you test this code?
test_clone_failure_stops_retries_only_when_github_denies_accesstotest_provision_sandbox.py, with three cases: no credentials, repository not found, and DNS failure.test_clone_failure_records_failed_latency_and_captures_command_result, covers only the generic failure path.test_provision_sandbox.pylocally.test_desktop_bootstrap_relaunch_replaces_a_running_buildfails, and it also fails on master in this sandbox, as fix(tasks): stop a run planning when it has no repository checkout #117823 noted.Release status
Docs update
None.
🤖 Agent context
Autonomy: Fully autonomous
Agent: PostHog Desktop (Claude Code), claude-opus-5-5
/writing-tests,/writing-pr-descriptions..gitguard, and it needs a workflow patch.Created with PostHog Desktop from this inbox report.
🤖 Generated with Claude Code